JuliaAI / ScientificTypes.jl

An API for dispatching on the "scientific" type of data instead of the machine type
MIT License
96 stars 8 forks source link

major updates #174

Closed OkonSamuel closed 2 years ago

OkonSamuel commented 2 years ago

This PR

  1. gets rid of nrows method from the Schema display
  2. update Schema constructor to reflect updates to Tables.Schema
  3. modify show behavior of Schema object
  4. make Schema object a Tables.jl compatible object, and
  5. improve performance of schema and scitype methods for small to medium size tables
  6. avoid schema errors for extremely wide tables.

Also partially address #137

ablaom commented 2 years ago

To do:

ablaom commented 2 years ago

Looks like there has been a drop in code coverage from 94% to 80%.

The revised schema.jl section is at only 66% : https://app.codecov.io/gh/JuliaAI/ScientificTypes.jl/blob/57f1c0e3d695283966a6bf1e4a8b8733bcd5b7a8/src/schema.jl

@OkonSamuel Could you have a look at adding a few pertinent tests to improve this?

OkonSamuel commented 2 years ago

Looks like there has been a drop in code coverage from 94% to 80%.

The revised schema.jl section is at only 66% : https://app.codecov.io/gh/JuliaAI/ScientificTypes.jl/blob/57f1c0e3d695283966a6bf1e4a8b8733bcd5b7a8/src/schema.jl

@OkonSamuel Could you have a look at adding a few pertinent tests to improve this?

@ablaom Okay, I'll take aa look at it today and add more tests.

codecov-commenter commented 2 years ago

Codecov Report

Merging #174 (57f1c0e) into dev (617bf2c) will decrease coverage by 14.52%. The diff coverage is 61.37%.

:exclamation: Current head 57f1c0e differs from pull request most recent head b299e87. Consider uploading reports for the commit b299e87 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #174       +/-   ##
===========================================
- Coverage   94.48%   79.95%   -14.53%     
===========================================
  Files           7        6        -1     
  Lines         290      424      +134     
===========================================
+ Hits          274      339       +65     
- Misses         16       85       +69     
Impacted Files Coverage Δ
src/convention/scitype.jl 54.54% <51.94%> (-22.60%) :arrow_down:
src/schema.jl 66.66% <64.13%> (-33.34%) :arrow_down:
src/autotype.jl 96.00% <82.35%> (-4.00%) :arrow_down:
src/ScientificTypes.jl 100.00% <100.00%> (ø)
src/coerce.jl 87.93% <100.00%> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 617bf2c...b299e87. Read the comment docs.

ablaom commented 2 years ago

I've checked the very latest codecov report manually, which is back around 94%, so good to go.