JuliaAI / ScientificTypes.jl

An API for dispatching on the "scientific" type of data instead of the machine type
MIT License
96 stars 8 forks source link

Get rid of `coerce!` DataFrames hack #192

Open ablaom opened 1 year ago

ablaom commented 1 year ago

At the moment coerce! is a variation of coerce that works in-place for data frames. But to avoid adding DataFrames as a dependency, there is a hack:

https://github.com/JuliaAI/ScientificTypes.jl/blob/10b332327e4723352d85699b4a119609d1062cd8/src/coerce.jl#L197

Now we have optional dependencies this hack can be removed.