search

JuliaAI / StatisticalTraits.jl

Other
3 stars 2 forks source link

update ScientificTypes to ScientificTypesBase #10

Closed OkonSamuel closed 3 years ago

OkonSamuel commented 3 years ago

In line with the migration of https://github.com/alan-turing-institute/ScientficTypes.jl` to https://github.com/JuliaAI/ScientificTypesBase.jl and https://github.com/JuliaAI/MLJScientificTypes.jl to https://github.com/JuliaAI/ScientificTypes.jl, this PR should be merged before https://github.com/JuliaAI/ScientificTypes.jl/pull/126 gets merged. cc. @ablaom cc. @juliohm

ablaom commented 3 years ago

@OkonSamuel Yes, good catch, thanks!

ablaom commented 3 years ago

@OkonSamuel

We need to fix tests as well: https://github.com/alan-turing-institute/StatisticalTraits.jl/blob/b5c8be1bc76bbbea7a97989398434847804d3f10/test/runtests.jl#L3

OkonSamuel commented 3 years ago

@OkonSamuel

We need to fix tests as well:

https://github.com/alan-turing-institute/StatisticalTraits.jl/blob/b5c8be1bc76bbbea7a97989398434847804d3f10/test/runtests.jl#L3 Yes