Closed alecloudenback closed 1 week ago
aplavin
commented
1 week ago I think it doesn't use Optimization@4 in the tests after this PR because of https://github.com/JuliaAPlavin/AccessibleOptimization.jl/blob/00000000deb8090071b289081b9db0d068c2eb22/test/Project.toml#L17-L18 But bumping those leads to tests failing. Would be great if you know how to fix those failures!
alecloudenback
commented
1 week ago Yes - I see what you mean. I had updated and seen v4 in the project env, not the test environment. Looks like the fix is to just explicitly add a ReverseDiff dependency. I updated the PR to include this and tests pass locally for me:
(AccessibleOptimization) pkg> test
Testing AccessibleOptimization
Status `/private/var/folders/ds/_tfd5bfd0bn51v_5xqxy821h0000gn/T/jl_lfuNWK/Project.toml`
[d88a00a0] AccessibleOptimization v0.1.1 `~/.julia/dev/AccessibleOptimization`
[4c88cf16] Aqua v0.8.7
[5224ae11] CompatHelperLocal v0.1.27
[8197267c] IntervalSets v0.7.10
[3aafef2f] OptimizationMetaheuristics v0.3.0
[36348300] OptimizationOptimJL v0.4.0
[37e2e3b7] ReverseDiff v1.15.3
[90137ffa] StaticArrays v1.9.7
[09ab397b] StructArrays v0.6.18
⌅ [f8b46487] TestItemRunner v0.2.3
⌅ [1c621080] TestItems v0.1.1
[8dfed614] Test v1.11.0
Status `/private/var/folders/ds/_tfd5bfd0bn51v_5xqxy821h0000gn/T/jl_lfuNWK/Manifest.toml`
[47edcb42] ADTypes v1.9.0
[621f4979] AbstractFFTs v1.5.0
[1520ce14] AbstractTrees v0.4.5
[d88a00a0] AccessibleOptimization v0.1.1 `~/.julia/dev/AccessibleOptimization`
[7d9f7c33] Accessors v0.1.38
[33016aad] AccessorsExtra v0.1.81
[79e6a3ab] Adapt v4.0.4
[66dad0bd] AliasTables v1.1.3
[4c88cf16] Aqua v0.8.7
[dce04be8] ArgCheck v2.3.0
[ec485272] ArnoldiMethod v0.4.0
[4fba245c] ArrayInterface v7.16.0
[a9b6321e] Atomix v0.1.0
[198e06fe] BangBang v0.4.3
[9718e550] Baselet v0.1.1
[e2ed5e7c] Bijections v0.1.9
[fa961155] CEnum v0.5.0
[d360d2e6] ChainRulesCore v1.25.0
[861a8166] Combinatorics v1.0.2
[38540f10] CommonSolve v0.2.4
[bbf7d656] CommonSubexpressions v0.3.1
[f70d9fcc] CommonWorldInvalidations v1.0.0
[34da2185] Compat v4.16.0
[5224ae11] CompatHelperLocal v0.1.27
[b152e2b5] CompositeTypes v0.1.4
[a33af91c] CompositionsBase v0.1.2
[88cd18e8] ConsoleProgressMonitor v0.1.2
[187b0558] ConstructionBase v1.5.8
[6add18c4] ContextVariablesX v0.1.3
[717857b8] DSP v0.7.10
[9a962f9c] DataAPI v1.16.0
[02685ad9] DataPipes v0.3.18
[864edb3b] DataStructures v0.18.20
[e2d170a0] DataValueInterfaces v1.0.0
[244e2a9f] DefineSingletons v0.1.2
[8bb1440f] DelimitedFiles v1.9.1
[85a47980] Dictionaries v0.4.2
[163ba53b] DiffResults v1.1.0
[b552c78f] DiffRules v1.15.1
⌅ [a0c0ee7d] DifferentiationInterface v0.5.17
[b4f34e82] Distances v0.10.11
[31c24e10] Distributions v0.25.112
[ffbed154] DocStringExtensions v0.9.3
[5b8099bc] DomainSets v0.7.14
[7c1d4256] DynamicPolynomials v0.6.0
[b7d42ee7] Einsum v0.4.1
[4e289a0a] EnumX v1.0.4
[e2ba6199] ExprTools v0.1.10
⌅ [6b7a57c9] Expronicon v0.8.5
[7a1cc6ca] FFTW v1.8.0
[cc61a311] FLoops v0.2.2
[b9860ae5] FLoopsBase v0.1.1
[9aa1b823] FastClosures v0.3.2
[1a297f60] FillArrays v1.13.0
[6a86dc24] FiniteDiff v2.24.0
[1fa38f19] Format v1.3.7
[f6369f11] ForwardDiff v0.10.36
[069b7b12] FunctionWrappers v1.1.3
[77dc65aa] FunctionWrappersWrappers v0.1.3
[46192b85] GPUArraysCore v0.1.6
[86223c79] Graphs v1.12.0
[1baab800] HybridArrays v0.4.16
[34004b35] HypergeometricFunctions v0.3.24
[615f187c] IfElse v0.1.1
[313cdc1a] Indexing v1.1.1
[d25df0c9] Inflate v0.1.5
[22cec73e] InitialValues v0.3.1
[18e54dd8] IntegerMathUtils v0.1.2
[8197267c] IntervalSets v0.7.10
[3587e190] InverseFunctions v0.1.17
[92d709cd] IrrationalConstants v0.2.2
[c8e1da08] IterTools v1.10.0
[82899510] IteratorInterfaceExtensions v1.0.0
[692b3bcd] JLLWrappers v1.6.0
[358108f5] JMcDM v0.7.17
[b14d175d] JuliaVariables v0.2.4
[63c18a36] KernelAbstractions v0.9.27
[2c470bb0] Kronecker v0.5.5
[5be7bae1] LBFGSB v0.4.1
[929cbde3] LLVM v9.1.2
[b964fa9f] LaTeXStrings v1.3.1
[984bce1d] LambertW v0.4.6
[23fbe1c1] Latexify v0.16.5
[1d6d02ad] LeftChildRightSiblingTrees v0.2.0
[d3d80556] LineSearches v7.3.0
[7a12625a] LinearMaps v3.11.3
[2ab3a3ac] LogExpFunctions v0.3.28
[e6f89c97] LoggingExtras v1.0.3
[d8e11817] MLStyle v0.4.17
[f1d291b0] MLUtils v0.4.4
[1914dd2f] MacroTools v0.5.13
[af67fdf4] ManifoldDiff v0.3.12
⌅ [1cead3c2] Manifolds v0.9.20
[3362f125] ManifoldsBase v0.15.16
[99c1a7ee] MatrixEquations v2.4.2
[bcdb8e00] Metaheuristics v3.3.5
[128add7d] MicroCollections v0.2.0
[e1d29d7a] Missings v1.2.0
[102ac46a] MultivariatePolynomials v0.5.6
[d8a4904e] MutableArithmetics v1.5.0
[d41bc354] NLSolversBase v7.8.3
[872c559c] NNlib v0.9.24
[77ba4419] NaNMath v1.0.2
[71a1bf82] NameResolution v0.1.5
[356022a1] NamedDims v1.2.2
[429524aa] Optim v1.9.4
[7f7a1694] Optimization v4.0.2
[bca83a33] OptimizationBase v2.0.4
[3aafef2f] OptimizationMetaheuristics v0.3.0
[36348300] OptimizationOptimJL v0.4.0
[bac558e1] OrderedCollections v1.6.3
[90014a1f] PDMats v0.11.31
[65ce6f38] PackageExtensionCompat v1.0.2
[d96e819e] Parameters v0.12.3
[f27b6e38] Polynomials v4.0.11
[85a6dd25] PositiveFactorizations v0.2.4
[aea7be01] PrecompileTools v1.2.1
[21216c6a] Preferences v1.4.3
[8162dcfd] PrettyPrint v0.2.0
[27ebfcd6] Primes v0.5.6
[33c8b6b6] ProgressLogging v0.1.4
[92933f4c] ProgressMeter v1.10.2
[43287f4e] PtrArrays v1.2.1
[1fd47b50] QuadGK v2.11.1
[94ee1d12] Quaternions v0.7.6
[c1ae055f] RealDot v0.1.0
[3cdcf5f2] RecipesBase v1.3.4
[731186ca] RecursiveArrayTools v3.27.0
[189a3867] Reexport v1.2.2
[ae029012] Requires v1.3.0
[37e2e3b7] ReverseDiff v1.15.3
[79098fc4] Rmath v0.8.0
[7e49a35a] RuntimeGeneratedFunctions v0.5.13
[0bca4576] SciMLBase v2.54.2
[c0aeaf25] SciMLOperators v0.3.10
[53ae85a6] SciMLStructures v1.5.0
[eb7571c6] SearchSpaces v0.2.0
[efcf1570] Setfield v1.1.1
[605ecd9f] ShowCases v0.1.0
[699a6c99] SimpleTraits v0.9.4
[47aef6b3] SimpleWeightedGraphs v1.4.0
[66db9d55] SnoopPrecompile v1.0.3
[a2af1166] SortingAlgorithms v1.2.1
[9f842d2f] SparseConnectivityTracer v0.6.5
[0a514795] SparseMatrixColorings v0.4.2
[276daf66] SpecialFunctions v2.4.0
[171d559e] SplittablesBase v0.1.15
[90137ffa] StaticArrays v1.9.7
[1e83bf80] StaticArraysCore v1.4.3
[10745b16] Statistics v1.11.1
[82ae8749] StatsAPI v1.7.0
[2913bbd2] StatsBase v0.34.3
[4c63d2b9] StatsFuns v1.3.2
[09ab397b] StructArrays v0.6.18
[4297ee4d] SymbolicAnalysis v0.3.0
[2efcf032] SymbolicIndexingInterface v0.3.31
[19f23fe9] SymbolicLimits v0.2.2
[d1185830] SymbolicUtils v3.7.1
[0c5d862f] Symbolics v6.13.1
[3783bdb8] TableTraits v1.0.1
[bd369af6] Tables v1.12.0
[8ea1fca8] TermInterface v2.0.0
[5d786b92] TerminalLoggers v0.1.7
⌅ [f8b46487] TestItemRunner v0.2.3
⌅ [1c621080] TestItems v0.1.1
[a759f4b9] TimerOutputs v0.5.24
[28d57a85] Transducers v0.4.82
[3a884ed6] UnPack v1.0.2
[a7c27f48] Unityper v0.1.6
[013be700] UnsafeAtomics v0.2.1
[d80eeb9a] UnsafeAtomicsLLVM v0.2.1
[f5851436] FFTW_jll v3.3.10+1
[1d5cc7b8] IntelOpenMP_jll v2024.2.1+0
[dad2f222] LLVMExtra_jll v0.0.34+0
[81d17ec3] L_BFGS_B_jll v3.0.1+0
[856f044c] MKL_jll v2024.2.0+0
[efe28fd5] OpenSpecFun_jll v0.5.5+0
[f50d1b31] Rmath_jll v0.5.1+0
[1317d2d5] oneTBB_jll v2021.12.0+0
[0dad84c5] ArgTools v1.1.2
[56f22d72] Artifacts v1.11.0
[2a0f44e3] Base64 v1.11.0
[ade2ca70] Dates v1.11.0
[8ba89e20] Distributed v1.11.0
[f43a241f] Downloads v1.6.0
[7b1f6079] FileWatching v1.11.0
[9fa8497b] Future v1.11.0
[b77e0a4c] InteractiveUtils v1.11.0
[4af54fe1] LazyArtifacts v1.11.0
[b27032c2] LibCURL v0.6.4
[76f85450] LibGit2 v1.11.0
[8f399da3] Libdl v1.11.0
[37e2e46d] LinearAlgebra v1.11.0
[56ddb016] Logging v1.11.0
[d6f4376e] Markdown v1.11.0
[a63ad114] Mmap v1.11.0
[ca575930] NetworkOptions v1.2.0
[44cfe95a] Pkg v1.11.0
[de0858da] Printf v1.11.0
[9a3f8284] Random v1.11.0
[ea8e919c] SHA v0.7.0
[9e88b42a] Serialization v1.11.0
[1a1011a3] SharedArrays v1.11.0
[6462fe0b] Sockets v1.11.0
[2f01184e] SparseArrays v1.11.0
[4607b0f0] SuiteSparse
[fa267f1f] TOML v1.0.3
[a4e569a6] Tar v1.10.0
[8dfed614] Test v1.11.0
[cf7118a7] UUIDs v1.11.0
[4ec0a83e] Unicode v1.11.0
[e66e0078] CompilerSupportLibraries_jll v1.1.1+0
[deac9b47] LibCURL_jll v8.6.0+0
[e37daf67] LibGit2_jll v1.7.2+0
[29816b5a] LibSSH2_jll v1.11.0+1
[c8ffd9c3] MbedTLS_jll v2.28.6+0
[14a3606d] MozillaCACerts_jll v2023.12.12
[4536629a] OpenBLAS_jll v0.3.27+1
[05823500] OpenLibm_jll v0.8.1+2
[bea87d4a] SuiteSparse_jll v7.7.0+0
[83775a58] Zlib_jll v1.2.13+1
[8e850b90] libblastrampoline_jll v5.11.0+0
[8e850ede] nghttp2_jll v1.59.0+0
[3f19e933] p7zip_jll v17.4.0+2
Info Packages marked with ⌅ have new versions available but compatibility constraints restrict them from upgrading.
Testing Running tests...
┌ Warning: Project has issues with [compat]
│ project = "/Users/alec/.julia/dev/AccessibleOptimization/Project.toml"
└ @ CompatHelperLocal ~/.julia/packages/CompatHelperLocal/4LI7I/src/CompatHelperLocal.jl:133
┌ Info: [compat] missing
└ name = "Statistics"
Suggested content:
[compat]
AccessorsExtra = "0.1.43"
ConstructionBase = "1.5.1"
DataPipes = "0.3.5"
Optimization = "3,4"
Reexport = "1.2.2"
Statistics = "1.11.1"
julia = "1.6"
┌ Warning: Project has issues with [compat]
│ project = "/Users/alec/.julia/dev/AccessibleOptimization/test/Project.toml"
└ @ CompatHelperLocal ~/.julia/packages/CompatHelperLocal/4LI7I/src/CompatHelperLocal.jl:133
┌ Info: [compat] missing
└ name = "ReverseDiff"
┌ Info: [compat] outdated
│ name = "TestItemRunner"
│ compat = (val = VersionSpec("0.2"), str = "0.2.0")
└ latest = v"1.0.5"
┌ Info: [compat] outdated
│ name = "TestItems"
│ compat = (val = VersionSpec("0.1"), str = "0.1.0")
└ latest = v"1.0.0"
Suggested content:
[compat]
Aqua = "0.8"
CompatHelperLocal = "0.1.24"
IntervalSets = "0.7.2"
OptimizationMetaheuristics = "0.3"
OptimizationOptimJL = "0.4"
ReverseDiff = "1.15.3"
StaticArrays = "1.5.6"
StructArrays = "0.6.8"
TestItemRunner = "0.2.0, 1.0.5"
TestItems = "0.1.0, 1.0.0"
julia = "1.6"
WARNING: both Metaheuristics and Base export "summary"; uses of it in module OptimizationMetaheuristics must be qualified
Test Summary: | Pass Total Time
Package | 70 70 37.6s
Testing AccessibleOptimization tests passed
(AccessibleOptimization) pkg> activate test
Activating project at `~/.julia/dev/AccessibleOptimization/test`
(test) pkg> st
Status `~/.julia/dev/AccessibleOptimization/test/Project.toml`
[4c88cf16] Aqua v0.8.7
[5224ae11] CompatHelperLocal v0.1.27
[8197267c] IntervalSets v0.7.10
[3aafef2f] OptimizationMetaheuristics v0.3.0
[36348300] OptimizationOptimJL v0.4.0
[37e2e3b7] ReverseDiff v1.15.3
[90137ffa] StaticArrays v1.9.7
[09ab397b] StructArrays v0.6.18
⌅ [f8b46487] TestItemRunner v0.2.3
⌅ [1c621080] TestItems v0.1.1
[8dfed614] Test v1.11.0
Info Packages marked with ⌅ have new versions available but compatibility constraints restrict them from upgrading. To see why use `status --outdated`I made this change (import ReverseDiff) to imitate how lib/OptimizationOptimJL/test/runtests.jl changed in https://github.com/SciML/Optimization.jl/compare/v3.28.0...v4.0.2.
aplavin
commented
1 week ago Thanks! I had some fixes locally, so rewrote the history a bit. Should be registered soon!
This was a relatively quick attempt to update. I ran into the error in the first commit on both Optimization v3 and v4, so included that change and the associated error message for your review.