search

JuliaAPlavin / FlexiJoins.jl

MIT License
7 stars 0 forks source link

Cardinality checks notation #7

Closed aplavin closed 4 months ago

aplavin commented 11 months ago

In GitLab by @jariji on Jul 15, 2023, 16:41

+ and * cardinality checks are cute but semantically odd. What do you think about taking a predicate instead, eg 

cardinality=(; a = >(0), b = ==(1))
aplavin commented 11 months ago

Yeah I guess it would be nice. Not a priority for now though, unless this causes actual issues in the code.

aplavin commented 10 months ago

I definitely like supporting predicates that make sense for cardinality (like >, in, etc). This was added, predicates should work now.

But after some thinking, I would prefer keeping + as well. It's a very common case, and A=+ is visually shorted and cleaner than A = >=(1) or even A = >(0).