search

JuliaAcademy / DataScience

Data Science in Julia course for JuliaAcademy.com, taught by Huda Nassar
https://juliaacademy.com/p/julia-for-data-science
MIT License
489 stars 257 forks source link

Project environment specification #1

Closed bkamins closed 4 years ago

bkamins commented 4 years ago

This is a great tutorial. I would recommend one small thing for you to consider to ensure a smooth student experience.

You could consider adding Project.toml and Manifest.toml to your repository, so that you are sure that the students work on the same environment setup as you have. In particular the first notebook will not work without warnings under DataFrames 0.21.0 (current release) + soon CSV.read will get deprecated from CSV.jl AFAIK (therefore using CSV.File and then using DataFrame constructor on it is recommended).

nassarhuda commented 4 years ago

Thanks for pointing this out!

I just added the toml files. I'll double check later and test that all notebooks are working correctly under this environment. Will close this issue then.

bkamins commented 4 years ago

I have just checked that https://github.com/JuliaAcademy/DataScience/blob/master/Project.toml currently contains only Plots.jl, and you seem to use many more packages in the tutorial.

nassarhuda commented 4 years ago

My bad. These were my "test" toml files and didn't realize that I uploaded the wrong ones. I changed them earlier today. Feel free to double check and see if things look good on your end.

bkamins commented 4 years ago

Looks good! Thank you.

(I stress this so much as my teaching experience is that problems with dependencies is a major issue for students).

nassarhuda commented 4 years ago

Thanks again for bringing it up! Will close this issue for now.