Closed Mo-Dabao closed 4 years ago
Thanks @Mo-Dabao for the translation!
@ViralBShah, I'm having a hard time adding @Roger-luo as a reviewer; it seems like I can only designate JC employees. Is there a way to work around that?
I've invited @roger-luo to the org. Perhaps we can add him then.
Thanks!
@Roger-luo I'm trying to go through and clean up some of the old PRs in this repo. Do you think this PR is good to merge as-is? It seems better to have at least something than to wait until it's perfect?
Or if you want to continue reviewing, please let me know! :) I'll give this a few days and merge it if I don't hear from you (probably on Tuesday of next week)
@NHDaly hi sorry I forgot to review this since last time, it's really an epic PR... but there was some translation notes were wrong in the part I reviewed, so I guess there might be some others part need to revise.
It'd be nice if we could do it with small PRs @Mo-Dabao
I'll try to spend some time reviewing it this month, and I could also post this on the Chinese discourse to see if people could help.
cc @logankilpatrick too
If it's too much to ~merge~ review, I'd also be supportive of just merging this and doing the improvements in small PRs over time, but totally up to y'all!
I would be ok with that
yeah, that'd work too. I just created a post on Chinese discourse to ask for help: https://discourse.juliacn.com/t/topic/2884/2
but true, as you said maybe let's just merge this first.
Probably should have a separate repo for the translations. What does everyone think?
I prefer to put those translations in a separate folder, not a new repo.
English files are located in the root directory, and Chinese translations are placed in the zh-cn
folder.
Just like: Learn X in Y minutes
If we're going to open a new repo, we'd better wait until everything is translated.
Ok. Makes sense. We can keep in the same repo.
Switched to use the file structure from "Learn X in Y minutes".
Going to merge unless there's last minute fixes required
Some of the easy part has been translated into Chinese. The left is beyond me for now. I think Julia is exciting, would be catchy to MATLAB users. However, most of my work can be done using Python, witch has a more active society from my view, and I decide to focus on using Python for now. Best wishes for Julia.