JuliaAcademy / JuliaTutorials

Learn Julia via interactive tutorials!
https://julialang.org/learning/
MIT License
1.26k stars 657 forks source link

Feature/mybinder ready #54

Open kopp opened 4 years ago

kopp commented 4 years ago

I created the necessary Project.toml so that this repo can be run on mybinder.org.

I tested this with my fork and got

https://mybinder.org/v2/gh/kopp/JuliaBoxTutorials/82e2f65176b96e9c2fa179c4b2d27cb0036e8492

which seemed to work fine.

I also left a mybinder link which should work with this repo once the PR is accepted.

NHDaly commented 4 years ago

Let's wait for a decision on the conversation in #56: as to how exactly we want the README to look. Thanks for this contribution! :)

Additionally, i'm torn about whether or not it's beneficial to have top-level .toml files in this repo:

I considered adding this myself, too, before I saw your PR. I'm still not sure which is the better choice.

kopp commented 4 years ago

Would it work to have multiple Package.toml files? One in the toplevel containing everything and multiple ones containing only "what is necessary" in the subfolders?

I'm pretty new to Julia myself and all I wanted was to play with it in jupyter -- which did not work without the Package.toml...

logankilpatrick commented 3 years ago

@kopp if you want to update this PR, happy to get it merged in. We need to update the binder link and update the ReadMe links and such. I also second the notion to not include a project.toml file here.