JuliaActuary / MortalityTables.jl

Easily Reference and use Actuarial Mortality Tables
https://juliaactuary.github.io/MortalityTables.jl/stable
Other
28 stars 10 forks source link

Fix parsing of CSVs change in v0.7.8 of CSV #95

Closed alecloudenback closed 3 years ago

alecloudenback commented 3 years ago

Before CSVv0.7.8, empty lines were read with missing values and the last_values_line looked for the missing row. Now, look for end of the files or for "Table" to indicate end of subtable

closes #93

codecov[bot] commented 3 years ago

Codecov Report

Merging #95 (98688f2) into master (b930e64) will increase coverage by 57.68%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #95       +/-   ##
===========================================
+ Coverage   33.22%   90.90%   +57.68%     
===========================================
  Files           7        8        +1     
  Lines         310      341       +31     
===========================================
+ Hits          103      310      +207     
+ Misses        207       31      -176     
Impacted Files Coverage Δ
src/CSV.jl 97.56% <100.00%> (+2.56%) :arrow_up:
src/death_distribution.jl 100.00% <0.00%> (ø)
src/XTbML.jl 67.90% <0.00%> (+3.70%) :arrow_up:
src/MortalityTable.jl 98.11% <0.00%> (+81.13%) :arrow_up:
src/parameterized_models.jl 98.05% <0.00%> (+98.05%) :arrow_up:
src/get_SOA_table.jl 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b930e64...45694b3. Read the comment docs.