search

JuliaAlgebra / DynamicPolynomials.jl

Multivariate polynomials implementation of commutative and non-commutative variables
Other
60 stars 20 forks source link

Antidifferentiate #130

Closed bmxam closed 2 months ago

bmxam commented 1 year ago

Implementation of MultivariatePolynomials.antidifferentiate function. I am more familiar with TypedPolynomials than with DynamicPolynomials so implementations improvements and/or comments are welcome. I did not find tests on the diff function so I did not provide tests for antidifferentiate. However, tests will be added in MultivariatePolynomials.jl (we first need to merge this PR before I can propose the tests).

blegat commented 1 year ago

Actually, you can add tests in MultivariatePolynomals now as we are doing a breaking release: https://github.com/JuliaAlgebra/MultivariatePolynomials.jl/issues/250 You can change the branches in .github/workflow/ci.yml so that ci works on the PR.

bmxam commented 1 year ago

Actually, you can add tests in MultivariatePolynomals now as we are doing a breaking release: JuliaAlgebra/MultivariatePolynomials.jl#250 You can change the branches in .github/workflow/ci.yml so that ci works on the PR.

Do you mean changing MultivariatePolynomials.jl/.github/workflow/ci.yml so that MultivariatePolynomials.jl ci works on the present PR?

blegat commented 1 year ago

Yes, see what was done in https://github.com/JuliaAlgebra/MultivariatePolynomials.jl/pull/255/files for instance

blegat commented 1 year ago

You can see an example in https://github.com/JuliaAlgebra/DynamicPolynomials.jl/pull/135, https://github.com/JuliaAlgebra/MultivariatePolynomials.jl/pull/268

bmxam commented 1 year ago

Thanks, I'll take a look asap.

blegat commented 2 months ago

Closed by https://github.com/JuliaAlgebra/DynamicPolynomials.jl/pull/158