search

JuliaAlgebra / DynamicPolynomials.jl

Multivariate polynomials implementation of commutative and non-commutative variables
Other
60 stars 21 forks source link

Inference crash upstream #18

Closed saschatimme closed 6 years ago

saschatimme commented 6 years ago

Here is a fun one. Since today we get consistent compiler / inference crashes in HomotopyContinuation.jl. Here are two run of travis for the same commit, one yesterday and one from today. The only difference is that the one from today uses DynamicPolynomials 0.0.4 instead of 0.0.3. So, some of the changes in the release seem to let the compiler fallover :(

saschatimme commented 6 years ago

For now we fixed this by fixing 0.0.3 as a dependency. I am also not sure there is much we can do here. I just hope that with 0.7 these kinds of bugs are gone...

blegat commented 6 years ago

Can you confirm that this is caused by this commit ? Does it crash when using differentiation ? promote_op does not seem to play nicely with Julia v0.7 and it is not recommended to use it so I changed it with typeof(...).

saschatimme commented 6 years ago

14 is the villain here. 370bc84f still works fine.

blegat commented 6 years ago

Ah, interesting. Do you have a MWE ?

saschatimme commented 6 years ago

Unfortunately not. The crash occurs during the precompilation of the dev branch of HomotopyContinuation.jl. But we also had previously problems with compiler crashes. Somehow the organization of our code in a lot of separate modules seems to trigger this kind of bug. But we also previously had these compiler crashes with TypedPolynomials or DynamicPolynomials if I remember correctly.