search

JuliaAlgebra / DynamicPolynomials.jl

Multivariate polynomials implementation of commutative and non-commutative variables
Other
60 stars 21 forks source link

Revert #14 for Julia 0.6 #25

Closed saschatimme closed 6 years ago

saschatimme commented 6 years ago

This reverts #14 for Julia 0.6 to adress #18. This is not really satisfactory, but I would appreciate if we could get this merged for the time until we all reach the 0.7 happy land.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.02%) to 98.613% when pulling 1c245d44fa21a397e91251e6b4b5fe11c2ad67ae on revert-#14 into 8b2b1a02fa687c97730402e5a52292affcbbcd88 on master.

codecov-io commented 6 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          15       15           
  Lines         721      721           
=======================================
  Hits          714      714           
  Misses          7        7
Impacted Files Coverage Δ
src/mono.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b2b1a0...1c245d4. Read the comment docs.

saschatimme commented 6 years ago

@blegat I was a little bit too tired yesterday and forgot to disable all of the corresponding testcases for 0.6 but not everything works.

This bug is really strange, since it isn't even called in my code (otherwise there would have been a stackoverflow), nonetheless it crashes the compiler 🤷‍♂️

blegat commented 6 years ago

Do you mean you get this crash ?