search

JuliaAlgebra / DynamicPolynomials.jl

Multivariate polynomials implementation of commutative and non-commutative variables
Other
60 stars 21 forks source link

Improve @polyvar #32

Closed saschatimme closed 6 years ago

saschatimme commented 6 years ago

This changes the behaviour of @polyvar to always return a tuple of the declared variables. The previous behaviour seems to lead to some confusion.

#previously
julia> @polyvar a b c
c

#now
julia> @polyvar a b c
(a, b, c)

This addresses [#]85(https://github.com/JuliaAlgebra/MultivariatePolynomials.jl/issues/85) in MultivariatePolynomials. cc @chriscoey

Note that this PR is currently against the 0.7 branch, I could backport this to 0.6 if there is some need to get this in a 0.6 release.

codecov-io commented 6 years ago

Codecov Report

Merging #32 into 0.7-only will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           0.7-only      #32      +/-   ##
============================================
+ Coverage     99.63%   99.63%   +<.01%     
============================================
  Files            14       14              
  Lines           546      554       +8     
============================================
+ Hits            544      552       +8     
  Misses            2        2
Impacted Files Coverage Δ
src/var.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 624c004...eb7968a. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.005%) to 99.639% when pulling eb7968ad007143fab191bc7d7bd2384cfb087485 on improve-polyvar into 624c004f6e127618780aeaea8a77a35c22e059bc on 0.7-only.

chriscoey commented 6 years ago

I'm only using v0.7 too

Thanks. Consistency is good!