search

JuliaAlgebra / DynamicPolynomials.jl

Multivariate polynomials implementation of commutative and non-commutative variables
Other
59 stars 21 forks source link

Check that variables are sorted for MonomialVector #40

Closed blegat closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.03%) to 76.414% when pulling 2bad83e1514d0a0a7d08eca1c014fe9ba5dd9942 on bl/sortedmonovec into 7e3e21c55e14bd8a63e81c81770cfc1c5dfa2d1d on master.

codecov-io commented 5 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   76.44%   76.41%   -0.04%     
==========================================
  Files          14       14              
  Lines         726      725       -1     
==========================================
- Hits          555      554       -1     
  Misses        171      171
Impacted Files Coverage Δ
src/monovec.jl 74.41% <100%> (-0.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e3e21c...2bad83e. Read the comment docs.

chriscoey commented 5 years ago

Did this fix some silent failures?

blegat commented 5 years ago

Not in any code that I already had but it does in some PR I am preparing for SumOfSquares

chriscoey commented 5 years ago

Good to know, thanks