Closed kalmarek closed 6 months ago
Attention: Patch coverage is 65.00000%
with 35 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
mk/non_monomial_basis@e1a6a6e
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
src/mtables.jl | 53.84% | 18 Missing :warning: |
src/diracs_augmented.jl | 65.90% | 15 Missing :warning: |
src/bases.jl | 0.00% | 1 Missing :warning: |
src/coefficients.jl | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ok, I have this running for the whole night with no crashes ;) seems like a fix, but a fix that I don't really understand :D
Good news, my plan is to merge https://github.com/jump-dev/SumOfSquares.jl/pull/351 and https://github.com/jump-dev/SumOfSquares.jl/pull/296 to have as much merged as possible without being blocked by StarAlgebras but then the follow up PR will make use of WeightedSOSCone by default which will require custom basis to handle the case with SOS modulo an ideal (I'm planning to implement it with a quotient basis). In the meantime, maybe we can merge these changes into StarAlgebras#master so that it's easier to deal with since I'll have to make MultivariateMoments, MultivariateBases, PolyJuMP and SumOfSquares depend on it
@blegat there is another "fix" to get going with MA:
this time I had to do this: https://github.com/JuliaAlgebra/StarAlgebras.jl/commit/56475bfcdf876d9fccc75b606d0b8f68ff83ce4c
I've also un-broken two tests that started passing with MA-1.4.3. However
MA.operate_to!(YY, +, Y, YY)
still fails with