JuliaAlgebra / StarAlgebras.jl

A package for computation in *-algebras with basis
MIT License
7 stars 3 forks source link

changes for SymbolicWedderburn #26

Closed kalmarek closed 6 months ago

kalmarek commented 7 months ago

@blegat there is another "fix" to get going with MA:

this time I had to do this: https://github.com/JuliaAlgebra/StarAlgebras.jl/commit/56475bfcdf876d9fccc75b606d0b8f68ff83ce4c

I've also un-broken two tests that started passing with MA-1.4.3. However MA.operate_to!(YY, +, Y, YY) still fails with

ERROR: ArgumentError: Cannot call `operate_to!(::SparseVector{Float64, Int64}, +, ::SparseVector{Float64, Int64}, ::SparseVector{Float64, Int64})` as objects of type `SparseVector{Float64, Int64}` cannot be modifed to equal the result of the operation. Use `operate_to!!` instead which returns the value of the result (possibly modifying the first argument) to write generic code that also works when the type cannot be modified.
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 65.00000% with 35 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (mk/non_monomial_basis@e1a6a6e). Click here to learn what that means.

Files Patch % Lines
src/mtables.jl 53.84% 18 Missing :warning:
src/diracs_augmented.jl 65.90% 15 Missing :warning:
src/bases.jl 0.00% 1 Missing :warning:
src/coefficients.jl 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## mk/non_monomial_basis #26 +/- ## ======================================================== Coverage ? 77.94% ======================================================== Files ? 14 Lines ? 603 Branches ? 0 ======================================================== Hits ? 470 Misses ? 133 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/JuliaAlgebra/StarAlgebras.jl/pull/26/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAlgebra) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/JuliaAlgebra/StarAlgebras.jl/pull/26/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAlgebra) | `77.94% <65.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAlgebra#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kalmarek commented 6 months ago

ok, I have this running for the whole night with no crashes ;) seems like a fix, but a fix that I don't really understand :D

blegat commented 6 months ago

Good news, my plan is to merge https://github.com/jump-dev/SumOfSquares.jl/pull/351 and https://github.com/jump-dev/SumOfSquares.jl/pull/296 to have as much merged as possible without being blocked by StarAlgebras but then the follow up PR will make use of WeightedSOSCone by default which will require custom basis to handle the case with SOS modulo an ideal (I'm planning to implement it with a quotient basis). In the meantime, maybe we can merge these changes into StarAlgebras#master so that it's easier to deal with since I'll have to make MultivariateMoments, MultivariateBases, PolyJuMP and SumOfSquares depend on it