JuliaApproximation / ApproxFunBase.jl

Core functionality of ApproxFun
MIT License
12 stars 13 forks source link

Change `conversion_type` to `hasconversion` in DefaultDerivative/Integral #473

Closed jishnub closed 1 year ago

jishnub commented 1 year ago

This seems to match the intent (as in the comment that follows). It also provides more freedom to conversion_type,

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 72.39% and project coverage change: -12.77 :warning:

Comparison is base (2f401fa) 71.22% compared to head (dd9b08c) 58.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #473 +/- ## =========================================== - Coverage 71.22% 58.46% -12.77% =========================================== Files 80 81 +1 Lines 8331 8385 +54 =========================================== - Hits 5934 4902 -1032 - Misses 2397 3483 +1086 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/ApproxFunBase.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL0FwcHJveEZ1bkJhc2Uuamw=) | `70.83% <ø> (-12.50%)` | :arrow_down: | | [src/LinearAlgebra/blas.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL0xpbmVhckFsZ2VicmEvYmxhcy5qbA==) | `0.00% <ø> (-77.78%)` | :arrow_down: | | [src/Spaces/Spaces.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL1NwYWNlcy9TcGFjZXMuamw=) | `35.71% <ø> (-31.35%)` | :arrow_down: | | [src/Spaces/SumSpace.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL1NwYWNlcy9TdW1TcGFjZS5qbA==) | `51.41% <33.33%> (-18.26%)` | :arrow_down: | | [src/Operators/functionals/CalculusFunctional.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9mdW5jdGlvbmFscy9DYWxjdWx1c0Z1bmN0aW9uYWwuamw=) | `54.28% <66.66%> (-18.13%)` | :arrow_down: | | [src/eigen.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2VpZ2VuLmps) | `66.66% <66.66%> (ø)` | | | [src/show.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL3Nob3cuamw=) | `52.63% <73.17%> (-30.21%)` | :arrow_down: | | [src/Operators/banded/CalculusOperator.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9iYW5kZWQvQ2FsY3VsdXNPcGVyYXRvci5qbA==) | `68.10% <77.41%> (-6.46%)` | :arrow_down: | | [src/Operators/Operator.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9PcGVyYXRvci5qbA==) | `61.85% <100.00%> (-5.73%)` | :arrow_down: | | [src/Operators/banded/Conversion.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9iYW5kZWQvQ29udmVyc2lvbi5qbA==) | `83.05% <100.00%> (+5.08%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | | ... and [59 files with indirect coverage changes](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/473/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.