search

JuliaApproximation / ApproxFunBase.jl

Core functionality of ApproxFun
MIT License
12 stars 13 forks source link

Use `LowRankMatrices` instead of `LowRankApprox` #511

Closed jishnub closed 1 year ago

jishnub commented 1 year ago

This improves the package load time. On master

julia> @time using ApproxFunBase
  8.988063 seconds (19.69 M allocations: 1.440 GiB, 3.62% gc time, 0.46% compilation time: 58% of which was recompilation)

This PR

julia> @time using ApproxFunBase
  7.450542 seconds (13.31 M allocations: 1.160 GiB, 3.67% gc time, 0.55% compilation time: 58% of which was recompilation)

These timings are on Julia v1.9.2

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -7.59% :warning:

Comparison is base (4f33475) 71.88% compared to head (136283b) 64.29%. Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #511 +/- ## ========================================== - Coverage 71.88% 64.29% -7.59% ========================================== Files 81 81 Lines 8546 8565 +19 ========================================== - Hits 6143 5507 -636 - Misses 2403 3058 +655 ``` | [Files Changed](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/ApproxFunBase.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL0FwcHJveEZ1bkJhc2Uuamw=) | `72.00% <ø> (-12.00%)` | :arrow_down: | | [src/Operators/general/InterlaceOperator.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9nZW5lcmFsL0ludGVybGFjZU9wZXJhdG9yLmps) | `76.00% <ø> (-5.34%)` | :arrow_down: | | [src/Fun.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL0Z1bi5qbA==) | `62.37% <100.00%> (-5.43%)` | :arrow_down: | | [src/LinearAlgebra/helper.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL0xpbmVhckFsZ2VicmEvaGVscGVyLmps) | `69.64% <100.00%> (+0.71%)` | :arrow_up: | | [src/Operators/banded/Conversion.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9iYW5kZWQvQ29udmVyc2lvbi5qbA==) | `87.09% <100.00%> (+0.65%)` | :arrow_up: | | [src/eigen.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2VpZ2VuLmps) | `90.47% <100.00%> (-5.96%)` | :arrow_down: | ... and [43 files with indirect coverage changes](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/511/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.