JuliaApproximation / ApproxFunBase.jl

Core functionality of ApproxFun
MIT License
12 stars 13 forks source link

Don't treat ConstantOperator as a zeroop #592

Closed jishnub closed 11 months ago

jishnub commented 11 months ago

This should make iszeroop an operation that works on types, and not values, which would help with type-inference

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage has no change and project coverage change: +4.62% :tada:

Comparison is base (fb1c8c4) 70.61% compared to head (1fef060) 75.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #592 +/- ## ========================================== + Coverage 70.61% 75.24% +4.62% ========================================== Files 80 80 Lines 8383 8419 +36 ========================================== + Hits 5920 6335 +415 + Misses 2463 2084 -379 ``` | [Files Changed](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/Operators/banded/ConstantOperator.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9iYW5kZWQvQ29uc3RhbnRPcGVyYXRvci5qbA==) | `80.68% <ø> (+7.64%)` | :arrow_up: | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/592/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.