search

JuliaApproximation / ApproxFunBase.jl

Core functionality of ApproxFun
MIT License
12 stars 13 forks source link

Remove fromcanonical in points for BivariateSpace #603

Closed jishnub closed 11 months ago

jishnub commented 11 months ago

Fix #602

After this,

julia> S = Chebyshev(1..2)⊗Chebyshev(3..4)
Chebyshev(1 .. 2) ⊗ Chebyshev(3 .. 4)

julia> [p ∈ domain(factor(S, 1)) for p in points(S, 10, 10)[1]]
10×10 Matrix{Bool}:
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1

julia> [p ∈ domain(factor(S, 2)) for p in points(S, 10, 10)[2]]
10×10 Matrix{Bool}:
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 81.57% and project coverage change: +0.04% :tada:

Comparison is base (28eb4ea) 75.24% compared to head (e042253) 75.28%. Report is 3 commits behind head on master.

:exclamation: Current head e042253 differs from pull request most recent head ea4668f. Consider uploading reports for the commit ea4668f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #603 +/- ## ========================================== + Coverage 75.24% 75.28% +0.04% ========================================== Files 80 80 Lines 8421 8435 +14 ========================================== + Hits 6336 6350 +14 Misses 2085 2085 ``` | [Files Changed](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/Fun.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL0Z1bi5qbA==) | `69.15% <0.00%> (+0.33%)` | :arrow_up: | | [src/Spaces/SubSpace.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL1NwYWNlcy9TdWJTcGFjZS5qbA==) | `66.32% <60.00%> (ø)` | | | [src/Spaces/ConstantSpace.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL1NwYWNlcy9Db25zdGFudFNwYWNlLmps) | `59.34% <77.77%> (+2.08%)` | :arrow_up: | | [src/Multivariate/TensorSpace.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL011bHRpdmFyaWF0ZS9UZW5zb3JTcGFjZS5qbA==) | `87.50% <91.66%> (+0.17%)` | :arrow_up: | | [src/Multivariate/TrivialTensorFun.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL011bHRpdmFyaWF0ZS9Ucml2aWFsVGVuc29yRnVuLmps) | `96.00% <100.00%> (ø)` | | | [src/Operators/SubOperator.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9TdWJPcGVyYXRvci5qbA==) | `84.31% <100.00%> (ø)` | | | [src/Operators/general/FiniteOperator.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9nZW5lcmFsL0Zpbml0ZU9wZXJhdG9yLmps) | `50.00% <100.00%> (+5.17%)` | :arrow_up: | | [src/Operators/general/InterlaceOperator.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL09wZXJhdG9ycy9nZW5lcmFsL0ludGVybGFjZU9wZXJhdG9yLmps) | `84.71% <100.00%> (ø)` | | | [src/constructors.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2NvbnN0cnVjdG9ycy5qbA==) | `80.95% <100.00%> (ø)` | | | [src/show.jl](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL3Nob3cuamw=) | `97.22% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaApproximation/ApproxFunBase.jl/pull/603/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.