JuliaApproximation / CompactBases.jl

Julia library for function approximation with compact basis functions
MIT License
16 stars 2 forks source link

CompatHelper: bump compat for QuasiArrays to 0.9, (keep existing compat) #53

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the QuasiArrays package from 0.4.9,0.5,0.6,0.7, 0.8 to 0.4.9,0.5,0.6,0.7, 0.8, 0.9. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 2 years ago

Codecov Report

Merging #53 (f5f9790) into master (fcb6a6b) will decrease coverage by 1.14%. The diff coverage is 100.00%.

:exclamation: Current head f5f9790 differs from pull request most recent head 89339e9. Consider uploading reports for the commit 89339e9 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   65.20%   64.05%   -1.15%     
==========================================
  Files          22       22              
  Lines        1615     1533      -82     
==========================================
- Hits         1053      982      -71     
+ Misses        562      551      -11     
Impacted Files Coverage Δ
src/fedvr_derivatives.jl 94.44% <100.00%> (-0.68%) :arrow_down:
src/finite_differences.jl 70.31% <100.00%> (-0.90%) :arrow_down:
src/materialize_dsl.jl 57.14% <0.00%> (-29.65%) :arrow_down:
src/bsplines.jl 76.25% <0.00%> (-1.89%) :arrow_down:
src/CompactBases.jl 87.50% <0.00%> (-1.39%) :arrow_down:
src/fedvr.jl 87.03% <0.00%> (-0.63%) :arrow_down:
src/fd_derivatives.jl 48.28% <0.00%> (-0.60%) :arrow_down:
src/linear_operators.jl 81.25% <0.00%> (-0.29%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcb6a6b...89339e9. Read the comment docs.

jagot commented 2 years ago

@dlfivefifty This update causes massive breakage, see e.g. https://github.com/JuliaApproximation/CompactBases.jl/runs/3866578135?check_suite_focus=true#step:6:166

I'm fine with dropping Julia < 1.6 and earlier {Quasi,Continuum}Arrays versions, and release CompactBases.jl as 0.4.0 if this simplifies fixing this.

dlfivefifty commented 2 years ago

Not surprised, it was a pretty big update (allows expansions with multiple columns, a step towards fast vector and matrix-functions)

jagot commented 2 years ago

@dlfivefifty Thanks! That seemed like an easy fix 😄

I fixed the failing documentation build which ran on Julia 1.5 previously.

dlfivefifty commented 2 years ago

This should be ready

jagot commented 2 years ago

Yep, thanks!

I guess this could be construed as breaking, but since nothing in the interface (from CompactBases.jl) changes, I'll just bump the patch number as usual.

dlfivefifty commented 2 years ago

I don't think it's breaking