Closed dlfivefifty closed 10 months ago
Now only overload plan_transform
and grid
: plan_grid_transform
won't be used anymore.
A consequence is that the default fallback transform of using Vandermonde+LeastSquares creates the grid twice. Whooptydoo.
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
5bcf055
) 91.59% compared to head (88f606e
) 91.69%. Report is 8 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
ext/ContinuumArraysMakieExt.jl | 0.00% | 3 Missing :warning: |
src/maps.jl | 92.30% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This refines the tensor transform interface. In particular:
grid(P)
andgrid(P,n::Int)
return just a vector of pointsgrid(P, (n,))
,grid(P, (m,n))
etc. return a tuple of vectors of points in each dimension.plan_grid_transform
.Thus one can do a 1D transform that gets out at least 5 coefficients via eg:
or a 2D transform
Note the "1D" and "2D" don't necessarily mean dimension of the geometry, eg, when combined with MultivariateOrthogonalPolynomials.jl the interface of a tensor product of disks would be:
@TSGut this might be of use for you.