JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

Move show for `Point` from `ApproxFun` #111

Closed jishnub closed 2 years ago

jishnub commented 2 years ago

On master

julia> Point(3)
Point{Int64}(3)

julia> Point(3.0)
Point{Float64}(3.0)

This PR

julia> Point(3)
Point(3)

julia> Point(3.0)
Point(3.0)
codecov[bot] commented 2 years ago

Codecov Report

Merging #111 (2683ff2) into master (a1224ed) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   85.71%   85.72%           
=======================================
  Files          31       31           
  Lines        2450     2451    +1     
=======================================
+ Hits         2100     2101    +1     
  Misses        350      350           
Impacted Files Coverage Δ
src/domains/point.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jishnub commented 2 years ago

Test failures seem unrelated

daanhb commented 2 years ago

Looks good, thanks

daanhb commented 2 years ago

@jishnub do you want this released? I think we could do that

jishnub commented 2 years ago

Yes. please tag this