JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

Remove isapprox for intervals which has been moved to IntervalSets #123

Closed dlfivefifty closed 1 year ago

daanhb commented 1 year ago

It seems the tests failed due to an isapprox check. Since isapprox moved, perhaps we can also remove the test from DomainSets, tag a new release, and worry about the error being thrown elsewhere?

dlfivefifty commented 1 year ago

OK agreed

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.09% // Head: 86.09% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (65fefcc) compared to base (8bce5e6). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #123 +/- ## ========================================== - Coverage 86.09% 86.09% -0.01% ========================================== Files 31 31 Lines 2496 2495 -1 ========================================== - Hits 2149 2148 -1 Misses 347 347 ``` | [Impacted Files](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/domains/interval.jl](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2RvbWFpbnMvaW50ZXJ2YWwuamw=) | `94.62% <ø> (-0.03%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.