JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

more changes in 0.6 #125

Closed daanhb closed 1 year ago

daanhb commented 1 year ago

These were some changes lined up for inclusion in 0.6. I propose we quickly make a 0.6.1 rather than waiting for 0.7.

It is breaking because of changes to intervals:

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.09% // Head: 85.83% // Decreases project coverage by -0.25% :warning:

Coverage data is based on head (1032cf9) compared to base (e3185fe). Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ========================================== - Coverage 86.09% 85.83% -0.26% ========================================== Files 31 31 Lines 2495 2626 +131 ========================================== + Hits 2148 2254 +106 - Misses 347 372 +25 ``` | [Impacted Files](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/domains/interval.jl](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2RvbWFpbnMvaW50ZXJ2YWwuamw=) | `88.81% <85.39%> (-5.81%)` | :arrow_down: | | [src/domains/point.jl](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2RvbWFpbnMvcG9pbnQuamw=) | `100.00% <100.00%> (ø)` | | | [src/generic/domain.jl](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2dlbmVyaWMvZG9tYWluLmps) | `93.65% <100.00%> (+1.71%)` | :arrow_up: | | [src/generic/lazy.jl](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2dlbmVyaWMvbGF6eS5qbA==) | `84.31% <100.00%> (+0.31%)` | :arrow_up: | | [src/generic/setoperations.jl](https://codecov.io/gh/JuliaApproximation/DomainSets.jl/pull/125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2dlbmVyaWMvc2V0b3BlcmF0aW9ucy5qbA==) | `92.21% <0.00%> (-0.60%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

daanhb commented 1 year ago

The biggest change I guess is this one. Before:

julia> using DomainSets

julia> (1..2) \ (2..3)
1..2

After:

julia> using DomainSets

julia> (1..2) \ (2..3)
1..2 (closed–open)
dlfivefifty commented 1 year ago

I agree, it's fine if v0.6.1 has more breaking changes