Closed daanhb closed 1 year ago
Base: 85.71% // Head: 85.73% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
927600a
) compared to base (1dd3a2e
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
We had the following asymmetric situation, where broadcast would work for
in
but not for∉
:This PR adds broadcast functionality for the
∉
method. The result is equivalent to typingA .∉ Ref(0..1)
instead.Currently, domains participate in broadcast using
DomainSetStyle
as broadcaststyle. A few functions, likein
and∉
are now supported by intercepting them during broadcast. There might be a more generic way to do it, but I didn't see it. In any case, using domains in conjunction with broadcast is possible by usingRef(d)
. We may want to be conservative in allowing justd
instead, andin
and∉
seem two valid special cases.