Should boundary(::Rectangle) use simpler types?

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements

MIT License

72 stars 12 forks source link

Should boundary(::Rectangle) use simpler types? #142

Closed dlfivefifty closed 5 months ago

dlfivefifty commented 9 months ago

I'm wondering if it would be more natural to have a notion of a rectangle embedded in a higher dimensional space rather than representing them as affine mapped rectangles... eg I would have expected the boundary of a 2D rectangle to be a union of LineSegments instead of affine mapped unit intervals.

I guess the two definitions are equivalent so maybe its just a question of making a type alias with prettier printing? That is, we could have LineSegment(a,b) create an affine mapped interval.

daanhb commented 9 months ago

Sure, we could have an alias. It would be good to have more general faces and edges etcetera, but of course multiple other packages provide that. I'd like to get #141 out of the way so that we can move on, I have some code depending on it in the meantime so I'll merge and fix any issues that arise.

daanhb commented 5 months ago

Dup of #100