search

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

factor out and improve maps code #158

Closed daanhb closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.54%. Comparing base (f04f919) to head (2a56497).

Files Patch % Lines
src/generic/lazy.jl 57.14% 3 Missing :warning:
src/generic/generator.jl 0.00% 1 Missing :warning:
src/generic/mapped.jl 94.44% 1 Missing :warning:
src/generic/productdomain.jl 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #158 +/- ## ========================================== + Coverage 87.34% 94.54% +7.20% ========================================== Files 35 25 -10 Lines 2828 1798 -1030 ========================================== - Hits 2470 1700 -770 + Misses 358 98 -260 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

daanhb commented 7 months ago

This PR moves all functionality involving maps into a submodule FunctionMaps. That submodule is structured like a package with a test suite that can run independently from that of DomainSets. It could be moved to a newly registered package.

For now, the DomainSets module imports all names from FunctionMaps that it had before, even internal ones. Thus, this is not a breaking change.

daanhb commented 6 months ago

All tests of the ApproxFun packages pass, this seems good to merge. I've fixed a lot of ambiguities using Aqua, test coverage has improved, and I've started extending the functionality of maps using a map-as-an-interface similar to domains.