search

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

Add Makie extension? #162

Open dlfivefifty opened 2 months ago

dlfivefifty commented 2 months ago

I might add a Makie extension for plotting rectangles, etc.

But how to deal with v1.6 support? Just Only support in in v1.9+?

daanhb commented 2 months ago

Is it possible to use extensions in 1.9 only while still remaining functional in 1.6? Or do you mean to make 1.9 only releases? In either case, I'm for it, because I can think of several Package extensions to make DomainSets integrate better (i.e. with GeometryBasics, I have some experiments in https://github.com/daanhb/DomainSetsExtensions.jl)

The alternative is to wait for the new LTS to land (on 1.10 I guess).

daanhb commented 2 months ago

On that topic, Meshes.jl supports plotting of various domains. The extension for Meshes.jl here was a proof-of-concept experiment to automatically translate DomainSets objects to Meshes objects, so that they can be plotted.

With some additions (developed by students at KU Leuven recently, not public) it's actually possible to take a triangle from GeometryBasics.jl, and via DomainSets.jl plot it using Meshes.jl.

dlfivefifty commented 2 months ago

There are three choices:

  1. I think extension are just ignored in older versions so plotting would only be supported in latest versions by default.
  2. Make extensions a hard dependency on versions that don't support Julia extensions. This is what is done in many packages eg: https://github.com/JuliaArrays/FillArrays.jl/blob/e2ec19d9b5ad6ae2eba95972d040bc37c098aa64/src/FillArrays.jl#L684
  3. Drop support for older versions of Julia.

I don't have a preference between the 3.