search

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

Make special interval displays consistent with IntervalSets #27

Closed dlfivefifty closed 4 years ago

dlfivefifty commented 5 years ago

I'm thinking instead of the chebyshev interval [-1,1], maybe -1 .. 1 (Chebyshev)

daanhb commented 4 years ago

It seems this was added somewhere along the way:

julia> ChebyshevInterval()
-1.0..1.0 (Chebyshev)

While we're at it, we could have:

julia> DomainSets.EmptySpace()
{} (empty domain)

and

julia> DomainSets.FullSpace()
{x} (complete space)

and I would propose to rename EmptySpace to EmptyDomain and to export it. I'm not sure about FullSpace. WholeDomain ? Complete domain?

daanhb commented 4 years ago

This is now in pull request #50. I've started using EmptySpace (now EmptyDomain) quite extensively elsewhere.

daanhb commented 4 years ago

I see that ApproxFun already uses EmptyDomain for something else, so I'll revert back to EmptySpace like it was. We can always change it later.

dlfivefifty commented 4 years ago

Don’t worry about ApproxFun, probably it’s just the same thing

daanhb commented 4 years ago

I've kept EmptySpace for now, since the other one is still called FullSpace. Closed by #50.