search

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

5 in ℝ returns false #51

Closed dlfivefifty closed 4 years ago

dlfivefifty commented 4 years ago 
julia> 5 in ℝ
false

Also, its weird that ℝ is a type, not an instance

daanhb commented 4 years ago

That is because these are spaces, not domains. I guess they should not be exported like that, and perhaps spaces can be removed altogether. Spaces were meant to give a mechanism to define embeddings and isomorphisms in a type-stable way.

If we define these as domains, then R, Q and friends are all FullSpaces. R could be defined asFullSpace{Float64}()?

dlfivefifty commented 4 years ago

Whatever the implementation, the behaviour 

julia> 5 in ℝ
false

is clearly wrong... FullSpace{Float64}() sounds fine as long as the above is fixed

daanhb commented 4 years ago

Okay, I made all of them into a FullSpace. Somehow, I think by locally activating the package for development, the version string is now 0.1.0 rather than 0.1 as before. We may want to bump it anyhow with the latest changes.