Closed daanhb closed 4 years ago
I have tentatively applied that change in #55. It seems to break ApproxFun, which was to be expected. The rename to isopenset
and isclosedset
is yet to happen.
@JuliaRegistrator register()
Registration pull request created: JuliaRegistries/General/13423
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.0 -m "<description of version>" f1a2bbb3c041ade4d82e4777fbaf0f2c42dd56e7
git push origin v0.3.0
In the package
IntervalSets
,isopen
andisclosed
will soon be renamed toisopenset
andisclosedset
(see https://github.com/JuliaMath/IntervalSets.jl/issues/59). We will have to follow suit.One issue I noticed is that the current definition of the boundary of an interval is unexpected. It does not include endpoints if the interval is open:
If an interval is seen as a subset of the real line, then its boundary includes both endpoints, regardless of whether the interval is open or not. I.e., I would expect:
Then, one could define the closure of an open interval as the corresponding closed interval, and the interior of the closed interval as the open one - the boundary would be the difference between the two.
Is there a reason for the current implementation? Now seems like a good time to change it.