rename isopen/isclosed/iscompact

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements

MIT License

72 stars 12 forks source link

rename isopen/isclosed/iscompact #60

Closed daanhb closed 4 years ago

daanhb commented 4 years ago

Reflecting the rename in IntervalSets version 0.5, we rename isopen/isclosed to isopenset/isclosedset. It seems to make sense to rename iscompact to iscompact set as well.

daanhb commented 4 years ago

I have kept iscompact like it was, instead of renaming it to compactset. It has to stop somewhere, we also have isempty and that is defined in Base for collections. This pull request supersedes #59.

dlfivefifty commented 4 years ago

Shall we get this merged and tagged?

daanhb commented 4 years ago

If it no longer breaks things - then yes

daanhb commented 4 years ago

This pull request does not change the version number, so 0.3.0 would include both the "vector" changes and the renames, which I guess is fine

dlfivefifty commented 4 years ago

Yes that’s fine