search

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

Level sets and indicator functions #78

Closed daanhb closed 3 years ago

daanhb commented 3 years ago

Work in progress for #75 and #76

codecov[bot] commented 3 years ago

Codecov Report

Merging #78 (565eb5e) into master (5d07798) will increase coverage by 11.28%. The diff coverage is 85.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #78       +/-   ##
===========================================
+ Coverage   73.67%   84.96%   +11.28%     
===========================================
  Files          25       26        +1     
  Lines        1193     1656      +463     
===========================================
+ Hits          879     1407      +528     
+ Misses        314      249       -65
Impacted Files Coverage Δ
src/DomainSets.jl 100.00% <ø> (ø)
src/maps/composite.jl 48.43% <46.66%> (-2.36%) :arrow_down:
src/maps/lazy.jl 61.11% <50.00%> (ø)
src/maps/basic.jl 65.90% <57.57%> (-22.81%) :arrow_down:
src/maps/map.jl 64.91% <68.75%> (+1.08%) :arrow_up:
src/generic/canonical.jl 75.00% <75.00%> (ø)
src/domains/cube.jl 78.87% <78.87%> (ø)
src/maps/arithmetics.jl 66.66% <80.00%> (+12.12%) :arrow_up:
src/generic/setoperations.jl 84.45% <81.03%> (+15.32%) :arrow_up:
src/maps/isomorphism.jl 81.81% <81.81%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d07798...565eb5e. Read the comment docs.

daanhb commented 3 years ago

This pull request is getting a bit more comprehensive than originally planned. I'll merge this soon with master and open a separate issue to discuss the design changes. I improved coverage a lot, which led to a lot of minor bug fixes. But there are also some syntax changes, so this is breaking.