JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

Move Test to [extras] #89

Closed cscherrer closed 2 years ago

cscherrer commented 2 years ago

Hi, I noticed Test is currently included in the deps block of Project.toml. This requires loading Test in order to use the package, which seems like unnecessary overhead. This little PR adds an extras section and moves Test there.

I also noticed cardinality is exported but undefined, so the PR removes this.

dlfivefifty commented 2 years ago

I think instead of removing cardinality it might be better to move the code that implements it here? I believe it’s in ContinuumArrays. We may have to add Infinities.jl as a dependency but that’s a lightweight package

codecov[bot] commented 2 years ago

Codecov Report

Merging #89 (ed55550) into master (8e9fc19) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          30       30           
  Lines        2384     2384           
=======================================
  Hits         2021     2021           
  Misses        363      363           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e9fc19...ed55550. Read the comment docs.

cscherrer commented 2 years ago

I think instead of removing cardinality it might be better to move the code that implements it here? I believe it’s in ContinuumArrays. We may have to add Infinities.jl as a dependency but that’s a lightweight package

Fair enough. This was an add-on anyway, so for now I've reverted that commit. So this PR now only updates Project.toml.

daanhb commented 2 years ago

Thanks @cscherrer, looks good