search

JuliaApproximation / DomainSets.jl

A Julia package for describing domains as continuous sets of elements
MIT License
72 stars 12 forks source link

cardinality is exported but undefined #90

Closed daanhb closed 2 years ago

daanhb commented 2 years ago

See #89

daanhb commented 2 years ago

@dlfivefifty what are the uses of the cardinality function? I only see it in this line. Currently, IntervalSets defines the width of an interval, and DomainSets defines the more general volume of a domain. I don't think we define any domains for which the cardinality would be finite, except perhaps vectors (seen as a domain) and a Point.

It may be interesting to define it, but does not seem essential to me. Does it have to be in DomainSets, or could it be defined in ContinuumArrays?

dlfivefifty commented 2 years ago

It can be in ContinuumArrays.jl. It's just used for the following:

julia> size(LinearSpline(range(0,1;length=10)))
(ℵ₁, 10)
daanhb commented 2 years ago

Okay, in that case I'll probably take it out here. I wonder if there are more exported-but-undefined symbols.

daanhb commented 2 years ago

Closed by #93

daanhb commented 2 years ago

It was the only one:

julia> using DomainSets

julia> filter(n -> ! isdefined(DomainSets,n), names(DomainSets))
1-element Vector{Symbol}:
 :cardinality