search

JuliaApproximation / GenericFFT.jl

A package for computing the FFT with arbitrary floating point numbers
MIT License
15 stars 4 forks source link

Reduce type piracy by shifting methods to AbstractFFTs #24

Open jishnub opened 1 year ago

jishnub commented 1 year ago

https://github.com/JuliaApproximation/GenericFFT.jl/blob/2e55016b642f5bdc7324a064b81f16dca6b967e4/src/GenericFFT.jl#L24-L33

These should ideally be moved to AbstractFFTs to reduce the type-piracy in this package.

daanhb commented 1 year ago

Yes, that would be more appropriate. Although it may have side-effects, but even then it would be worth fleshing them out.