JuliaApproximation / GenericFFT.jl

A package for computing the FFT with arbitrary floating point numbers
MIT License
15 stars 4 forks source link

Don't import unused names #39

Closed jishnub closed 11 months ago

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (50d0bf1) 82.50% compared to head (368ec71) 82.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ======================================= Coverage 82.50% 82.50% ======================================= Files 2 2 Lines 200 200 ======================================= Hits 165 165 Misses 35 35 ``` | [Files](https://app.codecov.io/gh/JuliaApproximation/GenericFFT.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/GenericFFT.jl](https://app.codecov.io/gh/JuliaApproximation/GenericFFT.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL0dlbmVyaWNGRlQuamw=) | `66.66% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

milankl commented 11 months ago

On this note, why do we import functions from FFTW, they technically should live in AbstractFFTs and both FFTW and GenericFFT should import those right?

jishnub commented 11 months ago

I think dct is defined in FFTW, and isn't provided by AbstractFFTs