search

JuliaApproximation / MultivariateOrthogonalPolynomials.jl

Supports approximating functions and solving differential equations on various higher dimensional domains such as disks and triangles
Other
17 stars 5 forks source link

Minor memory optimization for Zernike jacobi matrices #122

Closed TSGut closed 2 years ago

TSGut commented 2 years ago

Symmetric() means we don't actually have to store some zero bands when initially generating them.

codecov[bot] commented 2 years ago

Codecov Report

Merging #122 (c847428) into master (e065da9) will increase coverage by 0.26%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   95.97%   96.23%   +0.26%     
==========================================
  Files           4        4              
  Lines         720      718       -2     
==========================================
  Hits          691      691              
+ Misses         29       27       -2
Impacted Files Coverage Δ
src/disk.jl 98.22% <100.00%> (+0.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e065da9...c847428. Read the comment docs.

TSGut commented 2 years ago

@dlfivefifty Ready for merge.

dlfivefifty commented 2 years ago

(technically not a "memory optimization" as Zeros doesn't use any memory...)

TSGut commented 2 years ago

Interesting, I thought explicitly constructed zeros are still stored! In that case just a minor tidying of a redundancy. :)