Closed github-actions[bot] closed 2 years ago
@dlfivefifty, what's the reason the version requirement of HarmonicOPs.jl is restricted to a patch? Should it be set at a minor release?
Merging #129 (a838bd3) into master (63dc386) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 4 4
Lines 713 713
=======================================
Hits 686 686
Misses 27 27
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 63dc386...a838bd3. Read the comment docs.
I set it to a patch when I need a certain bug fix. This prevents being able to use an old version that won't actually work
But if someone updates their packages, they'll pull all upstream updates (unless they make a conscientious decision to pin), so it seems safe to set to minor releases? Without the addition of new features, one could view updates to Project.toml as bug fixes, so maybe there's an argument to not so tightly control the version.
It just sets the minimum version. This is correct as the package won’t work for early patched
So I guess the Harmonic OPs version has to be set to at least 0.2.6 due to the FastTransforms minor release?
It don’t think you understand how the versioning works… why would it need to be set to that? It just uses the newest version that’s more than 0.2.4
You're right I have no idea how it works. But what I'm thinking is that since HarmonicOPs.jl v0.2.4 has an upper bound on FastTransforms at 0.14-, then only v0.2.6 can be used with this repository now
That would be done automatically
This pull request changes the compat entry for the
FastTransforms
package from0.13
to0.13, 0.14
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.