search

JuliaApproximation / MultivariateOrthogonalPolynomials.jl

Supports approximating functions and solving differential equations on various higher dimensional domains such as disks and triangles
Other
17 stars 5 forks source link

Add derivatives for WeightedTriangle #179

Closed DanielVandH closed 2 months ago

DanielVandH commented 2 months ago

This PR adds support for derivatives of WeightedTriangle. Currently it only works for a, b, c > 0 since that is where the recurrence holds. Would it better to @assert this in the functions for the time being, or just leave it?

DanielVandH commented 2 months ago

Those errors seem unrelated to this change. I don't actually see that error at all when running the tests locally either...

dlfivefifty commented 2 months ago

Right, this is something I changed fixing plotting. I’ll have to fix it

dlfivefifty commented 2 months ago

I think the failures are due to a bug in FastTransforms.

dlfivefifty commented 2 months ago

@MikaelSlevinsky do you know why its crashing on Mac OS?

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.67%. Comparing base (089ad3c) to head (d7cecca).

Files Patch % Lines
src/triangle.jl 85.71% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #179 +/- ## ========================================== - Coverage 95.82% 95.67% -0.15% ========================================== Files 6 6 Lines 958 972 +14 ========================================== + Hits 918 930 +12 - Misses 40 42 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MikaelSlevinsky commented 2 months ago

Nope, but there will be changes coming in FastTransforms that will require new binaries, so I'm almost certain it's because they haven't been generated in a while.