search

JuliaApproximation / MultivariateOrthogonalPolynomials.jl

Supports approximating functions and solving differential equations on various higher dimensional domains such as disks and triangles
Other
17 stars 5 forks source link

Add DirichletTriangle #180

Closed DanielVandH closed 2 months ago

DanielVandH commented 2 months ago

This PR will eventually fully implement DirichletTriangle. Currently, only evaluation is fully implemented. Been working on implementing PartialDerivatives and expand which I'll add into here next. Also need to do the conversion matrices.

Reordered the files to separate the two triangle definitions, but looking at the diff now it's a bit confusing. I can put everything back into one place if needed.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 25.78616% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 84.93%. Comparing base (089ad3c) to head (e875ffc). Report is 1 commits behind head on master.

Files Patch % Lines
src/triangle/dirichlet_triangle.jl 0.00% 116 Missing :warning:
src/triangle/jacobi_triangle.jl 85.71% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #180 +/- ## =========================================== - Coverage 95.82% 84.93% -10.90% =========================================== Files 6 8 +2 Lines 958 1095 +137 =========================================== + Hits 918 930 +12 - Misses 40 165 +125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DanielVandH commented 2 months ago

Will close this for now while I instead look at supporting negative parameters in JacobiTriangle as a better approach for this.