search

JuliaApproximation / PiecewiseOrthogonalPolynomials.jl

A Julia package for piecewise spectral methods such as p-FEM
MIT License
6 stars 2 forks source link

Fix derivative by taking into account the changing interval sizes #16

Closed ioannisPApapadopoulos closed 1 year ago

ioannisPApapadopoulos commented 1 year ago

I had to change the how the affine transformation is done as the previous version was incompatible with ForwardDiff.

dlfivefifty commented 1 year ago

Can you get tests passing first?

ioannisPApapadopoulos commented 1 year ago

Yep, will do. My custom affine transform works with ForwardDiff but then is not 100% secure. I get BoundsError for values on the border of the domain. I guess the correct thing to do is get affine to play nice with ForwardDiff?

dlfivefifty commented 1 year ago

Base.unsafe_getindex might help

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.36% // Head: 97.41% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (542b68c) compared to base (68cdcb9). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16 +/- ## ========================================== + Coverage 97.36% 97.41% +0.05% ========================================== Files 1 1 Lines 152 155 +3 ========================================== + Hits 148 151 +3 Misses 4 4 ``` | [Impacted Files](https://codecov.io/gh/JuliaApproximation/PiecewiseOrthogonalPolynomials.jl/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/PiecewiseOrthogonalPolynomials.jl](https://codecov.io/gh/JuliaApproximation/PiecewiseOrthogonalPolynomials.jl/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL1BpZWNld2lzZU9ydGhvZ29uYWxQb2x5bm9taWFscy5qbA==) | `97.41% <100.00%> (+0.05%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ioannisPApapadopoulos commented 1 year ago

@dlfivefifty tests pass, happy to merge?