JuliaApproximation / PiecewiseOrthogonalPolynomials.jl

A Julia package for piecewise spectral methods such as p-FEM
MIT License
5 stars 1 forks source link

Fix derivative of hat functions for different sized intervals #17

Closed ioannisPApapadopoulos closed 1 year ago

ioannisPApapadopoulos commented 1 year ago

I realised that the derivative of the hat functions were giving the wrong conversion values if the elements were different sizes. Here is the fix.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.41% // Head: 97.40% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (a0ff621) compared to base (3a0fdcd). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17 +/- ## ========================================== - Coverage 97.41% 97.40% -0.02% ========================================== Files 1 1 Lines 155 154 -1 ========================================== - Hits 151 150 -1 Misses 4 4 ``` | [Impacted Files](https://codecov.io/gh/JuliaApproximation/PiecewiseOrthogonalPolynomials.jl/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/PiecewiseOrthogonalPolynomials.jl](https://codecov.io/gh/JuliaApproximation/PiecewiseOrthogonalPolynomials.jl/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL1BpZWNld2lzZU9ydGhvZ29uYWxQb2x5bm9taWFscy5qbA==) | `97.40% <100.00%> (-0.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ioannisPApapadopoulos commented 1 year ago

@dlfivefifty happy for me to merge?

ioannisPApapadopoulos commented 1 year ago

@dlfivefifty happy to merge?