JuliaApproximation / PiecewiseOrthogonalPolynomials.jl

A Julia package for piecewise spectral methods such as p-FEM
MIT License
6 stars 2 forks source link

reversecholesky restrictions #49

Open ioannisPApapadopoulos opened 10 months ago

ioannisPApapadopoulos commented 10 months ago

@dlfivefifty Does the @assert in https://github.com/JuliaApproximation/PiecewiseOrthogonalPolynomials.jl/blob/5c9cc9448b25c62b5b3b5301f12262dca864be29/src/arrowhead.jl#L281C5-L281C5 need to be there?

The matrices for the disk do not fit the exact format for reversecholesky currently implemented in PiecewisePolys and I error at this assert.

dlfivefifty commented 10 months ago

Did you try deleting it? It'll do the wrong thing probs unless you change the ranges of the for loops