search

JuliaApproximation / QuasiArrays.jl

A package for representing quasi-arrays
MIT License
12 stars 2 forks source link

resolve an ambiguity #102

Open putianyi889 opened 4 months ago

putianyi889 commented 4 months ago

Apparently Base._sum must accept a dim argument, otherwise _sum(f, A::something) and _sum(A::something, dim) technically introduce an ambiguity.

dlfivefifty commented 4 months ago

Can you add a test for the ambiguity?

codecov[bot] commented 4 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1f44868) 64.03% compared to head (78ed98d) 64.08%.

Files Patch % Lines
src/quasifill.jl 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #102 +/- ## ========================================== + Coverage 64.03% 64.08% +0.05% ========================================== Files 23 23 Lines 1824 1824 ========================================== + Hits 1168 1169 +1 + Misses 656 655 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

putianyi889 commented 4 months ago

Can you add a test for the ambiguity?

The ambiguity doesn't have any actual meaning I suppose. It just messes with the ambiguity check.

As for the coverage, I don't add any new lines so it doesn't change. Apparently the lines are never covered before.

dlfivefifty commented 4 months ago

But can you add tests that cover those lines? We need to make sure it hasn't broken anything.

putianyi889 commented 4 months ago

I don't even know the use case of QuasiFill. Is there a downstream that depends on it?

dlfivefifty commented 4 months ago

representing constant functions