search

JuliaApproximation / QuasiArrays.jl

A package for representing quasi-arrays
MIT License
12 stars 2 forks source link

DiagonalLayout for QuasiDiag #65

Closed dlfivefifty closed 3 years ago

dlfivefifty commented 3 years ago

@jagot this should fix https://github.com/JuliaApproximation/ContinuumArrays.jl/issues/87 though triggering a deprecation warning (for now).

jagot commented 3 years ago

@dlfivefifty Since https://github.com/JuliaMatrices/ArrayLayouts.jl/pull/61 is merged, is this up next?

dlfivefifty commented 3 years ago

Yes just adding another PR first before tagging

codecov[bot] commented 3 years ago

Codecov Report

Merging #65 (37632b0) into master (2b06122) will increase coverage by 0.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   55.14%   55.31%   +0.16%     
==========================================
  Files          20       20              
  Lines        1612     1618       +6     
==========================================
+ Hits          889      895       +6     
  Misses        723      723
Impacted Files Coverage Δ
src/QuasiArrays.jl 73.33% <ø> (ø)
src/quasidiagonal.jl 26.04% <ø> (+3.21%) :arrow_up:
src/quasipermutedims.jl 92.00% <100.00%> (+0.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b06122...37632b0. Read the comment docs.