search

JuliaApproximation / QuasiArrays.jl

A package for representing quasi-arrays
MIT License
12 stars 2 forks source link

Export domain #66

Closed mortenpi closed 3 years ago

mortenpi commented 3 years ago

domain() looks like the canonical way of accessing e.g. the domain of an Inclusion. Is it intentionally unexported or is that just an accidental omission?

codecov[bot] commented 3 years ago

Codecov Report

Merging #66 (fc12bf9) into master (2b06122) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   55.14%   55.14%           
=======================================
  Files          20       20           
  Lines        1612     1612           
=======================================
  Hits          889      889           
  Misses        723      723
Impacted Files Coverage Δ
src/QuasiArrays.jl 73.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b06122...fc12bf9. Read the comment docs.

dlfivefifty commented 3 years ago

There needs to be a bump in minor version as this is breaking.

I'm inclined not to export, for now, as I believe it leads to conflicts with ApproxFun. So I'd prefer to wait.

mortenpi commented 3 years ago

I'm inclined not to export, for now, as I believe it leads to conflicts with ApproxFun. So I'd prefer to wait.

That is fair. I'll go ahead and close this, since it's not actionable for the time being.

But just to clarify: while not exported, domain would still be considered part of the public API of QuasiArrays, right?

dlfivefifty commented 3 years ago

Yes I think so but to be fair I don't think it's a great interface, so may be redesigned in the future