JuliaApproximation / SemiclassicalOrthogonalPolynomials.jl

A Julia repository for semiclassical orthogonal polynomials
MIT License
7 stars 3 forks source link

Jp/twoband #64

Closed ioannisPApapadopoulos closed 1 year ago

ioannisPApapadopoulos commented 1 year ago

Fixed some tests and definition of TwoBand + added derivative and inner product for HalfWeighted{:ab} TwoBandJacobi(rho, 1, 1, 0)

ioannisPApapadopoulos commented 1 year ago

@dlfivefifty I would like to get this merged because it should fix the erroring in the pull request jp/annulus for AlgebraicCurveOrthogonalPolynomials.jl. The tests are failing but I do not think it's to do with a change I have made. It's complaining about not being able to create an infinite array during the tests in test_derivative.jl. Do you have any insights?

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.69% // Head: 92.83% // Increases project coverage by +0.13% :tada:

Coverage data is based on head (14034c4) compared to base (c5e5689). Patch coverage: 93.02% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #64 +/- ## ========================================== + Coverage 92.69% 92.83% +0.13% ========================================== Files 4 4 Lines 630 670 +40 ========================================== + Hits 584 622 +38 - Misses 46 48 +2 ``` | [Impacted Files](https://codecov.io/gh/JuliaApproximation/SemiclassicalOrthogonalPolynomials.jl/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation) | Coverage Δ | | |---|---|---| | [src/derivatives.jl](https://codecov.io/gh/JuliaApproximation/SemiclassicalOrthogonalPolynomials.jl/pull/64/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL2Rlcml2YXRpdmVzLmps) | `93.79% <ø> (ø)` | | | [src/SemiclassicalOrthogonalPolynomials.jl](https://codecov.io/gh/JuliaApproximation/SemiclassicalOrthogonalPolynomials.jl/pull/64/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL1NlbWljbGFzc2ljYWxPcnRob2dvbmFsUG9seW5vbWlhbHMuamw=) | `87.84% <66.66%> (+0.04%)` | :arrow_up: | | [src/twoband.jl](https://codecov.io/gh/JuliaApproximation/SemiclassicalOrthogonalPolynomials.jl/pull/64/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation#diff-c3JjL3R3b2JhbmQuamw=) | `95.83% <95.00%> (-0.66%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaApproximation)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.