JuliaApproximation / SemiclassicalOrthogonalPolynomials.jl

A Julia repository for semiclassical orthogonal polynomials
MIT License
7 stars 3 forks source link

StackOverflow when declaring type #81

Closed ioannisPApapadopoulos closed 1 year ago

ioannisPApapadopoulos commented 1 year ago

@dlfivefifty @TSGut

There is a StackOverflow error when declaring the type for SemiclassicalJacobi.

E.g.

julia> SemiclassicalJacobi(1.1,0,0,4)[0.2, 1]
1.0

julia> SemiclassicalJacobi{Float64}(1.1,0,0,4)[0.2, 1]
ERROR: StackOverflowError:
TSGut commented 1 year ago

I'll see if I can reproduce

TSGut commented 1 year ago

Whatever was causing this was already fixed in my PR branch, please check that it also fixes it for you.

TSGut commented 1 year ago

Ok this should just work now. The master branch was actually dangerously broken as a result of this, I have added a few small tests to avoid this repeating in the future.

ioannisPApapadopoulos commented 1 year ago

Thank you!