search

JuliaApproximation / SemiclassicalOrthogonalPolynomials.jl

A Julia repository for semiclassical orthogonal polynomials
MIT License
7 stars 3 forks source link

Broadcasting 0:∞ #95

Closed ioannisPApapadopoulos closed 7 months ago

ioannisPApapadopoulos commented 7 months ago

Hi @TSGut @dlfivefifty

Locally I am running into issues in v0.5.4 which are not present in v0.5.3. In v0.5.4 the following lazy broadcasting hangs:

using SemiclassicalOrthogonalPolynomials, ClassicalOrthogonalPolynomials
ρ = 0.5
t = inv(1-ρ^2)
Ps = SemiclassicalJacobi.(t,1,1,0:∞)

In v0.5.3 then ContinuumArrays is restricted to v0.16.4 and ClassicalOrthogonalPolynomials to v0.11.10.

Does this happen to you/do you know what is going on? Thanks!

TSGut commented 7 months ago

Yeah, it's the recent changes in ClassicalOPs.jl that cause this. We made some consistency adjustments that break the function calls, it's a simple fix.

Once my current PR in ClassicalOPs is merged I can sort this package, it shouldn't take me long. @dlfivefifty any chance we could review or merge said PR?

ioannisPApapadopoulos commented 7 months ago

Brilliant, thank you @TSGut !!

dlfivefifty commented 7 months ago

I've merged and tagged that PR.

But I don't need to review every PR, you could ask @ioannisPApapadopoulos or @MikaelSlevinsky to do it.

TSGut commented 7 months ago

Great, thanks! I will make a PR to fix SemiclassicalOPs today.